This repository was archived by the owner on Feb 28, 2024. It is now read-only.
Use the Arduino_MachineControl library on the M4 core of PMC#99
Closed
elastra21 wants to merge 1 commit intoarduino-libraries:masterfrom
Closed
Use the Arduino_MachineControl library on the M4 core of PMC#99elastra21 wants to merge 1 commit intoarduino-libraries:masterfrom
elastra21 wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
|
Memory usage change @ 589becb
Click for full report table
Click for full report CSV |
Collaborator
|
I'd rather fix at core level with something like |
Author
|
@facchinm Well that it'll be a better solution but for now I mean to allow to all the developers keep working would be great to fix that issue even if is a temporal patch. I found the solution months ago and right know that I start to work again with the PMC was complicated to find it again. |
Collaborator
|
Fixed by arduino/ArduinoCore-mbed@d9ce942 , will be available in the upcoming core release (3.5.x) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sorround the ArduinoRS485 dependency with a
https://github.com/elastra21/Arduino_MachineControl-ArduinoRS485/blob/589becb4a024f9c7922bd5bc9737338d653b702a/src/Arduino_MachineControl.h#L6-L8
and also the COMMClass
https://github.com/elastra21/Arduino_MachineControl-ArduinoRS485/blob/589becb4a024f9c7922bd5bc9737338d653b702a/src/Arduino_MachineControl.h#L111-L181
to avoid compilations error and can use the library in both cores.